Submitted by : simon at: 2005-02-06T17:30:49+00:00 (12 years ago)
Name :
Category : Severity : Status :
Optional subject :  
Optional comment :


comments:

One way to get this to work --EmmaLaurijssens, Thu, 16 Jun 2005 06:43:07 -0700 reply
Sorry it's not in proper diff format, but in backlinks.pt (0.42.0) at line 73, I changed:

  <a href="blurl" title=""
  tal:define="blid bl/id"
  tal:attributes="href python:here.wiki_url()+'/'+blid;
                  title bl/linkTitle|nothing;"
  tal:content="blpage"
  >blpage</a>

into:

  <span 
  tal:define="bltitle bl/Title"
  tal:replace="structure python:here.wikilink('['+bltitle+']')"
  ></span>

and so far, it works for me.

I must add --EmmaLaurijssens, Thu, 16 Jun 2005 15:04:28 -0700 reply
that this patch only addresses the issue in the backlinks section of the backlinks page, but it's quite easy to redo the rest of backlinks.pt in the same manner. In fact, [backlinks.pt]? is what I currently use as a replacement.

Frank's patch is in darcs now --betabug, Fri, 23 Feb 2007 15:05:47 +0000 reply
Status: open => closed

Looks nice! Congratulations and thanks to Frank!

I must add --simon, Fri, 23 Feb 2007 19:20:02 +0000 reply
Thanks Frank.. now I must add (boo! spoilsport!): I think it was the way it was for scalability reasons. wikilinking is more expensive - IIRC it requires at least touching/loading the zodb object for the page linked to. In large wikis and low memory/hosted situations this may noticeably slow down backlinks (and on a busy public wiki, possibly the whole zope server, since spiders are probably crawling all the backlinks all the time even though we encourage them not to).

Or, this may not be a problem at all, or it may be the right trade off. Just a heads up to be aware of this. I wish for.. a magic speed graph that shows us instantly when some change has impacted our scalability.

I must add --simon, Fri, 23 Feb 2007 19:31:53 +0000 reply
PS: but the code is much cleaner, so this can only be an improvement!

I must add --EmmaLaurijssens, Fri, 23 Feb 2007 21:02:35 +0000 reply
Tried it... getting the backlinks for IssueTracker on zwiki.org does take a while, but I can't tell the difference...