Submitted by : simon at: 2005-03-14T09:26:56+00:00 (12 years ago)
Name :
Category : Severity : Status :
Optional subject :  
Optional comment :

The first quoted section at #1070 is not formatted for some reason.


space before the > --betabug, Thu, 15 Mar 2007 09:08:17 +0000 reply
Status: open => closed

It doesn't work in #1070, because there is a space in front of the >. According to the code this will not work. Closing this unless someone changes the specs... :-)

For example:

this is a regular blockquote. I have no space in front of the >

This is not working: > Not a blockquote, there are lots of > > all over the place, > which isn't really nice, but that's life. > > It happens because I have a in front of the > > at the start of lines.

can't get it to work in #1318, reopening --betabug, Thu, 15 Mar 2007 12:24:13 +0000 reply
Status: closed => open

Either it needs docs good enough for a dummy like me, or else there is something not working.

can't get it to work in #1318, reopening --simon, Sat, 24 Mar 2007 05:00:27 +0000 reply
I see it works in stx pages but not in rst pages.

For anyone else looking at this, here's what I just figured out. This is an extra markup rule which Zwiki applies in the body of comments (only): blocks of lines which have > as their first character are rendered in a blockquote type=cite tag, which most browsers render with a blue line down the left side of the text. It's useful when you reply to a wikimail and quote the previous poster.

The preRender method (in and, eg) calls preRenderMessages which calls preRenderMessage which calls renderCitationsIn. Since all of these behave differently depending on page type, they are methods of the page type object which every zwiki page uses to do page-type-specific rendering bits. renderCitationsIn is implemented by PageTypeBase? (doing nothing) and PageTypeHtml? (adding the blockquote tag we want); PageTypeStx? inherits the latter but (aha!) PageTypeRst? subclasses PageTypeBase?, so inherits the null implementation of renderCitationsIn.

The fix ? I think PageTypeRst? needs its own renderCitationsIn method. These render helper methods, like makeCommentHeading, can be tricky though; depending where they are called in the rendering process, the markup rules applied later (the RST rules in this case) may mess with their output. We can't just output straight HTML this time, as RST will quote it. You can sometimes but not always quote the markup in such a way that it passes through the later rendering stages unharmed, creating the desired end result in the web browser. RST doesn't leave much room for this kind of hackery, I'm not sure it's going to be possible for this case.

... --simon, Sat, 24 Mar 2007 05:05:45 +0000 reply
Name: #1073 quoted text not always formatted => #1073 quoted text in comments is not formatted in rst pages Category: user-browsing => user-editing-rst

we seem to be removing something from RST here --betabug, Tue, 03 Jun 2008 05:52:02 -0700 reply
... because according to RST specs, we should get a "literal block" when we start lines with >, see: