Submitted by : simon at: 2006-08-11T13:55:47+00:00 (11 years ago)
Name :
Category : Severity : Status :
Optional subject :  
Optional comment :

An rst page is created, it needs to be stx. Check the other page installations as well.

Added type=stx --EmmaLaurijssens, Fri, 23 Feb 2007 13:54:24 +0000 reply

in tracker.py, line 561-564:

self.create(page,
            text=open(os.path.join(dir,page+'.dtml'),'r').read(),
            sendmail=0,
            type='stx')

allow_dtml --EmmaLaurijssens, Fri, 23 Feb 2007 15:01:59 +0000 reply

These pages are only valid when DTML is allowed. Added a line to allow dtml for these pages, tracker.py line 565:

self.pageWithName(page).manage_addProperty('allow_dtml',1,'boolean')

You're not going to add these pages and not allowing them to use DTML, so adding the property automatically makes sense.

allow_dtml --EmmaLaurijssens, Fri, 23 Feb 2007 15:53:21 +0000 reply

Just to be sure, it might be wise not to implicitly add the allow_dtml property. I've added a second property, dtml, to accomodate this.

Frank's fix is in darcs --betabug, Fri, 23 Feb 2007 15:57:26 +0000 reply

Status: open => closed

Since it sets up dtml for those 3 pages (which might or might not be what people expect) he added another parameter that has to be given to explicitly enable this step:

/setupTracker?pages=1&dtml=1

is what is required to enable dtml for those pages too. Maybe this needs to be documented somewhere too.

suggestion --simon, Fri, 23 Feb 2007 18:59:15 +0000 reply

Status: closed => open

Yes, I'd rather not enable DTML in any unexpected way, since it has security implications.

I think it's understood/documented that if you're installing the tracker as pages you know what you're doing, and when you see the pages not working you'll know clearly that you're having to enable DTML in your wiki also..

I'm also not happy with the user having to remember N magic config options in the url.. one is already bad enough. Of course what we'd really like is a nice button or wizard that sets it all up, with appropriate warnings and explanations.

suggestion --EmmaLaurijssens, Fri, 23 Feb 2007 19:12:49 +0000 reply

I was just about to get back to this as I'm not entirely happy with it either...

suggestion --EmmaLaurijssens, Fri, 23 Feb 2007 20:41:19 +0000 reply

I just submitted a patch that just sets the stx page type, nothing more

... --EmmaLaurijssens, Mon, 26 Feb 2007 08:40:34 +0000 reply

Status: open => closed

Idea: self-documenting code --betabug, Mon, 26 Feb 2007 21:07:38 +0000 reply

Just had this idea how we could "self-document" this. If we add something like this somewhere at the top of the pages, then the information what to do is right there:

<dtml-comment>
dtml not enabled
This page looks not right, because it needs dtml enabled to work correctly. You can enable dtml for this page only, the procedure is described at "somelink".
</dtml-comment>

The part in the dtml-comment tags will only be displayed when dtml is disabled, while the dtml-comment tag itself is ignored by browsers. The part inside the dtml-comment could give detailed instructions together with a short security reminder. We could even get featuritis and make a method that sets it up per-page and then we could provide a button that sets it up for the viewed page (when permissions are right).

Putting a simple version into darcs.