Submitted by : simon at: 2007-03-24T16:04:49+00:00 (10 years ago)
Name :
Category : Severity : Status :
Optional subject :  
Optional comment :

Comments are stored in mbox format, with unique Message-id: headers which look like email addresses but aren't. This message id also appears in links to comments. From here it is harvested by spambots and my mail server ends up seeing thousands of failing delivery attempts to these bogus addresses. I'm pretty sure these ids can be anything so let's make them not look like email addresses.

actually --simon, Sat, 24 Mar 2007 16:23:28 +0000 reply

Actually, the @ does seem to be required by the standard (http://www.faqs.org/rfcs/rfc2822.html). Isn't this problem pretty widespread then ? I guess if you never show the message-id on a web page it doesn't arise.

We want a reliable unique url for a comment, preferably one that still works if comments are moved around on the page or to another page, but we probably don't need the full message id for this. Instead of

http://zwiki.org/1318TagsInterface#msg20070324045414+0000@zwiki.org

how about

http://zwiki.org/1318TagsInterface#msg20070324045414+0000

ie just the timestamp. That should still work even if the comment is moved around, which I think is desirable. (Though one could argue it doesn't happen often and so a simple msg1, msg2 would suffice).

Note the target must begin with a letter to be standards-compliant. I'm tempted to use the more communicative "comment" instead of "msg".

Comments are frequently moved around in my wiki --JózsefJároli, Mon, 26 Mar 2007 08:53:45 +0000 reply

Well my wiki is getting more and more similar to a forum, not because the page editing is currently not allowed, but there is a lively community there, so people are often asking questions from each other. Since some of these questions are many times asked at a wrong page, or sometimes I just open a new entry based on an interesting thread, that's why the existing comments are to be moved to a more adecuate or to a newly created page quite often.

Comments are frequently moved around in my wiki --Simon Michael, Mon, 26 Mar 2007 14:17:41 +0000 reply

Ok good to know, we'll keep the full timestamp.

actually --EmmaLaurijssens, Mon, 26 Mar 2007 14:26:00 +0000 reply

The msgid is generated by the originating mail server. This means that in order to keep them unique, removing the @domain portion just doesn't do the trick.

Currently, messages that I mail in, have an @thuis.laurijssens.nl suffix. This host resolves to 127.0.0.1 on the internet. I acknowledge that this will not work for everyone either, so a solution should come from ZWiki. IMHO we could replace the @, or append an extension, like .bogus or .127-0-0-1.nl (the latter would always resolve to 127.0.0.1, if I'd register the domain ;) )

actually --Simon Michael, Mon, 26 Mar 2007 17:46:07 +0000 reply

Oh darn.. I was thinking of the comments zwiki generates. Of course some of them are mailed in.

How wrong would it be to simply drop the @... part nevertheless ? The first part is going to end up being effectively unique on any typical wiki I'm pretty sure.

actually --EmmaLaurijssens, Mon, 26 Mar 2007 21:11:22 +0000 reply

yes, won't be a big deal, I think.

... --simon, Fri, 27 Apr 2007 02:58:26 +0000 reply

I've started work on this.. it needs a bit of refactoring.

See also #1165 --betabug, Fri, 04 May 2007 10:12:35 -0700 reply

#1165CommentReplyLinkHasSiteUrlHardcodedIntoIt goes hand-in-hand with this one I would say.

... --simon, Mon, 07 May 2007 23:54:36 -0700 reply

Severity: normal => minor