Submitted by : nobuyuki-koyoshi at: 2007-10-22T10:59:40-07:00 (10 years ago)
Name :
Category : Severity : Status :
Optional subject :  
Optional comment :

I found a same issue in editform.pt as #1376 (with 0.60.0) and #1330 (with 0.59.0).

When clicking preview bottom after typed Non-ascii characters in 'Optional change note' with IE6. Non-ascii characters of 'Optional change note' are broken.

I think tal:attributes="value log;" (editform.pt 136 line) is not safty. It should be tal:attributes="value python: here.talsafe(log);".

How do you think this patch?

Adding same patch for subscribeform.pt --koyoshi, Tue, 23 Oct 2007 03:51:27 -0700 reply

/ZWiki/skins/zwiki/subscribeform.pt (at 49 line and 153 line) have a same problem for non-ascii charachers.

subscribeform.pt's patch:

diff -du subscribeform.pt_org subscribeform.pt_for_non_ascii_characters
--- subscribeform.pt_org        2007-10-23 17:57:01.000000000 +0900
+++ subscribeform.pt_for_non_ascci_characters   2007-10-23 19:29:05.000000000 +0900
@@ -46,7 +46,7 @@
               Or return to
             </span>
             <a href="page_url" tal:attributes="href here/pageUrl"
-               tal:content="here/pageName">Page name</a>.
+               tal:content="python:here.talsafe(here.pageName())">Page name</a>.
           </p>
           <div tal:condition="inCMFAndLoggedIn">
             <input name="email" type="hidden" tal:attributes="value email" />
@@ -150,7 +150,7 @@
                      tal:attributes="href python:
                                      '%s/%s/subscribeform?email=%s' % (
                                      here.wiki_url(),pageid,here.urlquote(email))"
-                     tal:content="python:here.pageWithId(pageid).pageName()"
+                     tal:content="python:here.talsafe(here.pageWithId(pageid).pageName())"
                      >pagename</a>
                 </span>
               </td>