Submitted by : betabug at: 2007-12-21T06:23:39-08:00 (9 years ago)
Name :
Category : Severity : Status :
Optional subject :  
Optional comment :

This patch http://joyful.com/darcsweb/darcsweb.cgi?r=ZWiki;a=commitdiff;h=20071030083921-b6ddc-89c0d289e287ab4989bf195d507a6ac33e442a64.gz removed the setVotes method, which revert tries to call.

Needed for the fix:

Got a patch --betabug, Sat, 22 Dec 2007 01:47:44 -0800 reply

The following patch will solve the problem and allow revert() to re-apply the ratings again:

hunk ./plugins/rating/rating.py 107
+
+    security.declarePrivate('setVotes')
+    def setVotes(self, votes):
+        """
+        Private accessor. Still needed for reverting edits.
+        """
+        self = getattr(self,'aq_base',self)
+        self._votes = votes
+        self.ensureVotesIsBtree()

Tried to send this to patches@, but nothing arrived :-(

Sent to patches@ --betabug, Sat, 22 Dec 2007 01:56:42 -0800 reply

Problem with mail sending was on my side.

Sent some new tests to patches@ too --betabug, Sun, 23 Dec 2007 04:26:09 -0800 reply

The new functional tests would have catched this bug (but in hindsight it's much easier to claim that :-)

installed --simon, Fri, 18 Jan 2008 09:54:17 -0800 reply

This should be working better now.

in darcs, installed on zwiki.org - closing this --betabug, Wed, 23 Jan 2008 12:34:20 +0000 reply

Status: open => closed