Submitted by : simon at: 2003-10-26T21:32:10+00:00 (14 years ago)
Name :
Category : Severity : Status :
Optional subject :  
Optional comment :

In Mail._upgradeSubscribers(), (I understood that) we try to get the old subscribers-related properties. Well, good idea, but after the first guess with "subscribers" (l.80 and next), where we set 'oldsubs', we set 'oldsubs' to 'None' before trying with "_subscribers".

I guess we should definitely not set 'oldsubs' to 'None'. ;)

Here is a patch, in case you really want one

--- Mail.py.orig      Thu Jun 26 12:53:10 2003
+++ Mail.py   Thu Jun 26 12:53:27 2003
@@ -89,7 +89,6 @@
             changed = 1

         # migrate a wikifornow _subscribers attribute
-        oldsubs = None
         if hasattr(f, '_subscribers'):
             oldsubs = f._subscribers.keys()
             try:

property change --Wed, 08 Oct 2003 05:35:58 -0700 reply

Severity: minor => serious

noone is upgrading from WikiForNow --SimonMichael, Sun, 12 Oct 2003 20:09:15 -0700 reply

Severity: serious => minor

fixed for 0.24 --SimonMichael, Sun, 12 Oct 2003 20:17:31 -0700 reply

property change --SimonMichael, Sun, 12 Oct 2003 20:17:36 -0700 reply

property change --SimonMichael, Sun, 12 Oct 2003 20:17:48 -0700 reply

Status: open => closed