Submitted by : simon at: 2003-10-26T21:32:36+00:00 (14 years ago)
Name :
Category : Severity : Status :
Optional subject :  
Optional comment :

Problem

The breadcrumbs in wikipage_view.pt have problems with links to pages that have spaces in their ids.

So, here's the path that fixes this.

JoachimBauch?, bauch@struktur.de

Part 1 - Generate correct <a> tags

Patch / Diff:

Index: ZWikiPage.py
===================================================================
RCS file: /cvsroot/zwiki/zwiki/ZWikiPage.py,v
retrieving revision 0.453
diff -c -r0.453 ZWikiPage.py
*** ZWikiPage.py        4 Sep 2003 05:53:04 -0000       0.453
--- ZWikiPage.py        10 Sep 2003 09:11:37 -0000
***************
*** 639,644 ****
--- 639,645 ----
          Find and render all links in text.
          """
          t = self.applyLineEscapesIn(text)
+         t = self.canonicalIdFrom(t)
          t = re.sub(anywikilinkexpr,
                     thunk_substituter(self.renderLink, t, 1),
                     t)

Part 2 - Don't render breadcrumb separator after last link

Patch / Diff:

Index: skins/zwiki_plone/wikipage_view.pt
===================================================================
RCS file: /cvsroot/zwiki/zwiki/skins/zwiki_plone/wikipage_view.pt,v
retrieving revision 1.4
diff -c -r1.4 wikipage_view.pt
*** skins/zwiki_plone/wikipage_view.pt  15 Aug 2003 05:27:23 -0000      1.4
--- skins/zwiki_plone/wikipage_view.pt  10 Sep 2003 09:11:38 -0000
***************
*** 18,24 ****
      <tal:ancestors condition="here/ancestorsAsList"
                     repeat="ancestor here/ancestorsAsList">
          <span tal:replace="structure python:here.wikilink(ancestor)"></span>
!         &raquo;
      </tal:ancestors>
      </small>
--- 18,24 ----
      <tal:ancestors condition="here/ancestorsAsList"
                     repeat="ancestor here/ancestorsAsList">
          <span tal:replace="structure python:here.wikilink(ancestor)"></span>
!         <tal:block tal:condition="not: repeat/ancestor/end">&raquo;</tal:block>
      </tal:ancestors>
      </small>

(new) --Simon Michael, Wed, 10 Sep 2003 02:25:17 -0700 reply

I think this may already be fixed in 0.22.. thanks.

... --Wed, 10 Sep 2003 02:27:53 -0700 reply

Hmm, actually I used the CVS version from SourceForge? and it didn't work there...

Joachim

... --Simon Michael, Wed, 10 Sep 2003 02:35:12 -0700 reply

Ok - perhaps rename this page to IssueNoNNNN? ... so it will not be lost..

... --Wed, 10 Sep 2003 02:46:26 -0700 reply

So should I create an issue in the IssueTracker first and link it from there?

... --Simon Michael, Wed, 10 Sep 2003 03:20:57 -0700 reply

> So should I create an issue in the IssueTracker first and link it from > there?

No need.. just rename this page and it will be as if you had added an issue. I think 603 is the next free number, so perhaps "IssueNo0603? various breadcrumb fixes"

... --Wed, 10 Sep 2003 04:10:31 -0700 reply

Sorry, I can't rename the page as I can't login and thus don't have the right permissions... Is there a way to create an account here?

... --Simon Michael, Wed, 10 Sep 2003 05:30:53 -0700 reply

You don't need to log in, but you will need to save a username in UserOptions? in order to rename. There is more at http://zwiki.org/FAQs#How%20do%20I%20rename%20a%20page?

, let me know if it's still unclear.

renamed --Magog, Wed, 10 Sep 2003 05:41:09 -0700 reply

Thanks, just renamed it.

property change --Magog, Wed, 10 Sep 2003 05:41:43 -0700 reply

Category: => general Status: => open

property change --Magog, Wed, 10 Sep 2003 05:42:11 -0700 reply

Title: 'IssueNo0603? - various breadcrumb fixes' => 'IssueNo0603? various breadcrumb fixes'

fixed for 0.23 --simon, Thu, 25 Sep 2003 20:32:46 -0700 reply

I fixed the freeform links (in wikipage_view.pt). I left the raquo as-is, I think it's supposed to indicate that the list ends with the current page's name. Thanks.

property change --simon, Thu, 25 Sep 2003 20:33:09 -0700 reply

Status: open => closed

... --betabug, Wed, 21 Feb 2007 08:18:37 +0000 reply

Name: '#603 meda' => '#603 various breadcrumb fixes' Category: user-editing-html => general Severity: critical => normal Status: open => closed