Submitted by : SimonMichael at: 2003-11-16T15:27:41+00:00 (14 years ago)
Name :
Category : Severity : Status :
Optional subject :  
Optional comment :

... --SimonMichael, Sun, 16 Nov 2003 16:31:35 -0800 reply

Partially fixed.. it will now use the wikipage_macros on the filesystem as a fallback.

However, the page still appears unstyled unless there is a stylesheet.css in the folder. I'm not sure how to provide a default stylesheet. Can we put styles in wikipage.pt or wikipage_macros.pt, yet have them overridden by a stylesheet.css in the zodb ?

fixed --SimonMichael, Sun, 16 Nov 2003 19:22:10 -0800 reply

Status: open => closed

from the change log: --SimonMichael, Sun, 16 Nov 2003 19:40:59 -0800 reply

The default skin was not finding it's macros or stylesheet in an simple
(non SkinnedFolder), uncustomized wiki folder. It now uses two new UI methods,
wikipage_macros() and stylesheet(), to provide defaults for these.
stylesheet() is slightly more tricky than the others: it can be overridden
with a file/page template/dtml method named either "stylesheet" or
"stylesheet.css", the former taking precedence (possibly we
should say just "stylesheet.css"; it must support that one to work in a
skinned folder setup); and it tries to set a sensible last-modified
header. Note currently the stylesheet will be loaded at least once per
page since it's linked with a per-page url. An alternative would be to
inline it.

Feedback welcome. It would be nice to avoid the extra stylesheet loading caused by per-page stylesheet urls. The only way I can think to do that right now (while still providing a default) is to always inline it. Or is there some simpler solution to all this ?

stylesheet loading? --DanMcmullen, Mon, 17 Nov 2003 07:58:54 -0800 reply

what is your specific performance concern with stylesheet loading? the stylesheet text is loaded per page with inlining. is it the stylesheet page fetch overhead?

why is it necessary to link the stylesheet with a per-page url?

i'll grab the latest code & take a look at it.

**Re: [IssueNo0646? 0.25cvs: default skin is broken in a simple folder
since it can't find wikipage_macros] stylesheet loading?** --Simon Michael, Mon, 17 Nov 2003 18:18:37 -0800 reply

> what is your specific performance concern with stylesheet loading? the > stylesheet text is loaded per page with inlining. is it the stylesheet > page fetch overhead?

That's true. Yes, it's the extra fetch I'm wanting to avoid.

> why is it necessary to link the stylesheet with a per-page url?

Just linking to a stylesheet in the folder is natural and simple, but there may not be a stylesheet there. So in that case I saw the default skin come up, but unstyled. It was almost ok that way, but I'd like it to have the default appearance even when all you have is a single wiki page in a folder. By getting it from a method of ZWikiPage, I can provide a default when necessary (similar to editform, backlinks etc). Does this explain it ?

Can you think of another way to provide a styled default skin when there is no stylesheet in the zodb ?

property change --simon, Mon, 25 Oct 2004 21:07:51 -0700 reply

Name: '#646 0.25cvs: default skin is broken in a simple folder since it can't find wikipage_macros' => '#646 zwiki 0.25cvs: default skin is broken in a simple folder since it can't find wikipage_macros'