Submitted by : Magog at: 2004-01-28T01:43:06+00:00 (13 years ago)
Name :
Category : Severity : Status :
Optional subject :  
Optional comment :

After adding a comment to a page, no mail is sent if the mailout_policy is set to edits and the method quickcomment of ZWiki.Editing.EditingSupport? is used.

Here is a patch against the current CVS version that fixes this:

  RCS file: /cvsroot/zwiki/zwiki/Editing.py,v
  retrieving revision 1.18
  diff -c -r1.18 Editing.py
  *** Editing.py  25 Jan 2004 17:44:12 -0000      1.18
  --- Editing.py  28 Jan 2004 09:39:16 -0000
  ***************
  *** 219,224 ****
  --- 219,229 ----
                self.setLastEditor(REQUEST)
                self.setLastLog(note)
                self.updateCatalog()
  +             # send out mail notification
  +             if getattr(self.folder(),'mailout_policy','')=='edits':
  +                 self.sendMailToSubscribers(
  +                     self.textDiff(a=oldtext,b=self.read()),
  +                     REQUEST=REQUEST, subject=subject)

            # if mailout policy is comments only, send it now
            # (otherwise append did it) # XXX refactor

Joachim Bauch (bauch@struktur.de)


comments:

thank you, fixed for 0.27 --SimonMichael, Wed, 28 Jan 2004 16:38:30 -0800 reply
Status: open => closed