Submitted by : 127.0.0.1 at: 2004-03-25T12:19:02+00:00 (13 years ago)
Name :
Category : Severity : Status :
Optional subject :  
Optional comment :

CHANGES.txt states for 0.25:

Unfortunately, the value in Default.py is ignored and ZWiki always generates a placeholder. The problem is, that the checkbox for leaveplaceholder in wikipage_macros.pt:406 is only hidden but always present in the rendered page. Therefore, the parameter leaveplaceholder for the method rename is set to the string "0", which evaluates to true.

Either the code for the checkbox has to be completely removed from the rendered page (so leaveplaceholder is not set and Defaults.LEAVE_PLACEHOLDER is used instead), or the condition for placeholders in the method rename has to be changed. Why not change the TAL condition for the checkbox to something like:

  python:user.has_permission('Zwiki: Rename pages',here) and hasattr(here, 'leaveplaceholder')

This way you could control the generation of placeholders via a property on the Wikis folder. This may also resolve #579 renaming issue page via editform leaves unwanted placeholder.

PS: It may be, that LEAVE_PLACEHOLDER is still ignored. It is only used once as default value for parameter leaveplaceholder of the method rename, but most (all?) methods calling rename already provide a value of their own and their default value for leaveplaceholder is 1.


comments:

yes --SimonMichael, Thu, 25 Mar 2004 17:18:38 -0800 reply
Thank you, this was bugging me. However I would rather not add yet another option the admin has to think about (unless they are so keen as to change Defaults.py). Can we just say it works one way or the other ?

Another option? -- Thu, 25 Mar 2004 23:47:08 -0800 reply
Personally, I prefer no placeholders, and I constantly find me deleting them manually. So from my point of view they should be disabled by default or at least I should be allowed to disable them. I don't mind if I have to change a line in Defaults.py or to set a property for doing this.

However, I always hesitate to change the ZWiki source code, because I have to maintain these changes for the next releases to come, which is really cumbersome and error prone. Therefore, I like the properties like issue_severities, allow_dtml and so on: they will stay when you upgrade the ZWiki product and you even can apply them selectively to Wikis, whereas changes in the source code affect all Wikis on the same server. But your mileage may vary. :-)

--Andreas

fixed for 0.30 - LEAVE_PLACEHOLDER is king --simon, Sat, 10 Apr 2004 18:28:40 -0700 reply
Status: open => closed