Submitted by : DeanG at: 2004-10-10T10:16:46+00:00 (13 years ago)
Name :
Category : Severity : Status :
Optional subject :  
Optional comment :

no need to re-enter edit page when in that page.

"e" is the same accelerator for the browser's Edit menu, which contains copy, paste, and other editing functions. If overriden, will cause grief when overwriting existing view with last view.

See http://zwiki.org/UserDiscussion#msg20041008190733-0700@zwiki.org

more confusing to have access keys sometimes on, sometimes off ? --simon, Sun, 30 Jan 2005 12:07:52 -0800 reply

Severity: serious => normal

... --Fri, 02 Dec 2005 08:38:17 -0800 reply

This is a bug I have to keep patching around for my wife on her Zwiki. It'd be handy to have it fixed.

more confusing to have access keys sometimes on, sometimes off ? --TomPurl, Fri, 02 Dec 2005 08:50:30 -0800 reply

I think that removing these links would actually significantly less confusing for almost all of your users. ZWiki definitely has different types of pages, and only the actions that can performed on a page should be part of that page. Just my two cents.

more confusing to have access keys sometimes on, sometimes off ? --simon, Fri, 02 Dec 2005 09:11:07 -0800 reply

Do you mean, remove access key shortcuts entirely ?

more confusing to have access keys sometimes on, sometimes off ? --tom, Fri, 02 Dec 2005 12:06:45 -0800 reply

No, I just mean that the we should remove access key shortcuts/links from a page if you can't (or shouldn't) execute that action against that page. That makes sense to me (for whatever that's worth :).

more confusing to have access keys sometimes on, sometimes off ? --Simon Michael, Sat, 03 Dec 2005 08:09:34 -0800 reply

Ah. Well I agree that at least in this case we should disable E, it does indeed allow unlucky users to "lose" their edits. It might require a little thought because the access keys come from a shared macro IIRC. Patches welcome.

make a slot in that macro --betabug, Tue, 13 Feb 2007 06:32:41 -0800 reply

Make a slot in that macro, around the part in question. Then this specific template can "whiteout" that slot, thereby disabling the access key in question.

ok --simon, Sat, 17 May 2008 12:23:35 -0700 reply

Status: open => closed

Thanks for the fix. I'm not so happy with complicating access keys, which are tricky enough already - also I think browsers have changed their keybindings to clash less with menu shortcuts now - but reloading and "losing" your edit in progress is definitely annoying so let's do this.

patch is in -unstable darcs --betabug, Sat, 17 May 2008 12:46:15 -0700 reply

The slot path didn't work (because macros seem to be nested?), we're now setting a variable and using a tal:condition-block. Not as elegant, but works.

but --simon, Fri, 30 Jan 2009 15:10:13 -0800 reply

Status: closed => open

now there's no e access key at all when viewing eg this page. Is the above patch doing too much ?

fixed --simon, Sat, 14 Feb 2009 00:04:37 -0800 reply

Severity: minor => normal Status: open => closed