Edit detail for GeneralDiscussion revision 102 of 541

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541
Editor: FrankLaurijssens
Time: 2007/11/08 06:37:54 GMT-8
Note:

removed:
-From simon Wed Sep 5 13:23:01 -0700 2007
-From: simon
-Date: Wed, 05 Sep 2007 13:23:01 -0700
-Subject: Plone/Wicked, Zwiki comparison
-Message-ID: <20070905132301-0700@zwiki.org>
-
-FYI, I've updated http://zwiki.org/PloneAndCMF#zwiki-and-wicked.
-
-From simon Thu Sep 6 16:17:38 -0700 2007
-From: simon
-Date: Thu, 06 Sep 2007 16:17:38 -0700
-Subject: darcs doc update
-Message-ID: <20070906161738-0700@zwiki.org>
-
-New/updated:
-
-- http://zwiki.org/DarcsRepos#how-to-check-out-a-copy-of-zwiki 
-- http://zwiki.org/DarcsRepos#how-to-upgrade-downgrade-your-repo-to-a-known-version
-
-
-From NeilMcEvoy Sat Sep 8 05:43:57 -0700 2007
-From: NeilMcEvoy
-Date: Sat, 08 Sep 2007 05:43:57 -0700
-Subject: how do ZWiki home page
-Message-ID: <20070908054357-0700@zwiki.org>
-
-I love the zwiki.org home page style. is there a quick how to on how it's done? I've looked around the site, but can't find how to do stuff like the nice coloured boxes, the centred text etc. Thanks!
-
-From SimonMichael Sat Sep 8 08:59:39 -0700 2007
-From: Simon Michael
-Date: Sat, 08 Sep 2007 08:59:39 -0700
-Subject: how do ZWiki home page
-Message-ID: <op.tycepmvhhse33c@dynabook.joyful.com>
-In-Reply-To: <20070908054357-0700@zwiki.org>
-
-Hey Neil, welcome. It's just hand-tweaked html (FrontPage uses structured  
-text + html instead of restructured text). See it via the edit link,  
-external edit link, or by appending /src to the url.
-
-
-From NeilMcEvoy Sun Sep 9 05:58:37 -0700 2007
-From: NeilMcEvoy
-Date: Sun, 09 Sep 2007 05:58:37 -0700
-Subject: Plone integration
-Message-ID: <20070909055837-0700@zwiki.org>
-
-My main goal is plone integration, and I see there's a lot of info to read. A quick question: ZWiki Folders allows me to select membership controls, such as 'role to add wiki pages' = 'expert' etc. Will these be site-wide, or will they fit in with how I'm trying to use mxmWorkgroups, which is limit the role to that group, ie a group wiki can only be edited by an expert for that group, or will it mean any expert can edit any wiki?
-
-many thanks! Neil.
-
-From flemmingbjerke Wed Sep 12 03:53:57 -0700 2007
-From: flemmingbjerke
-Date: Wed, 12 Sep 2007 03:53:57 -0700
-Subject: Spam
-Message-ID: <20070912035357-0700@zwiki.org>
-
-It is necessary to pay more attention to spam. Even zwiki.org has had spam problems:
-
-http://zwiki.org/1279IssuetrackerSpamIsStillAProblemCloseHolesAndRepairIssuesOnZwikiOrgElsewhere
-
-We need to have open zwiki where whoever wants to comment, can comment. But, we cannot do that due to spammers. I have tried to apply plonecaptcha, but I haven't succeeded in having zwiki to validate captcha. I think zwiki should have default opportunity where anonymous user must use captcha.
-
-From betabug Wed Sep 12 04:29:32 -0700 2007
-From: betabug
-Date: Wed, 12 Sep 2007 04:29:32 -0700
-Subject: Spam
-Message-ID: <20070912042932-0700@zwiki.org>
-In-Reply-To: <20070912035357-0700@zwiki.org>
-
-Have you tried setting edits_need_username ? Did it change anything for you there? See for example the LinkSpam page for details.
-
-From SimonMichael Wed Sep 12 08:37:40 -0700 2007
-From: Simon Michael
-Date: Wed, 12 Sep 2007 08:37:40 -0700
-Subject: Spam
-Message-ID: <op.tyjsc5t0hse33c@dynabook.joyful.com>
-In-Reply-To: <20070912042932-0700@zwiki.org>
-
-As betabug says, see http://zwiki.org/LinkSpam - that page has the current  
-know-how for dealing with Zwiki spam. So far these methods have been  
-sufficient for all zwikis I know about. Patches to integrate with  
-PloneCaptcha would be interesting.
-
-
-From val Fri Sep 14 03:39:28 -0700 2007
-From: val
-Date: Fri, 14 Sep 2007 03:39:28 -0700
-Subject: upload image inplace
-Message-ID: <20070914033928-0700@zwiki.org>
-
-Hi all, I have created a bit of javascript code that uses the upload functionality embedded in Zwiki to upload images. It all works fine, the upload works fine, but the image is always put under the text, instead of where the cursor is. Does anyone have a clue why?
-
-From betabug Sat Sep 15 06:45:40 -0700 2007
-From: betabug
-Date: Sat, 15 Sep 2007 06:45:40 -0700
-Subject: upload image inplace
-Message-ID: <20070915064540-0700@zwiki.org>
-In-Reply-To: <20070914033928-0700@zwiki.org>
-
-Unless you have changed any Zwiki python code, the uploads are on the server handled by the handleFileUpload() method (in Editing.py), which - after handling all the file uploading business - will call _addFileLink() (also in Editing.py). _addFileLink() searches the text of the current page for a link to the freshly uploaded image. If no such link (href or src) is found, and satisfying some other tests, it adds a link to the image at the end of the wiki page in question.
-
-So I'd say that if your javascript also adds a link to that image at the cursor position and properly sends in the "edited" page text to the server **at the same time** as uploading the image, then the image should not appear at the end of the page.
-
-From simon Sat Sep 15 09:19:37 -0700 2007
-From: simon
-Date: Sat, 15 Sep 2007 09:19:37 -0700
-Subject: release status
-Message-ID: <20070915091937-0700@zwiki.org>
-
-Hi all.. I have not felt ready to release 0.60 final yet due to a number of uglyish plone and encoding-related issues. You can see them in IssueTracker. I haven't been able to spend time on these during the week. Good news, Sascha Welter is back to zwiki hacking as of today and this will help a lot. Anyone else with a little time here and there, please do hang out on #zwiki and help if you can. Many hands make light work!
-
-From simon Sat Sep 15 15:25:08 -0700 2007
-From: simon
-Date: Sat, 15 Sep 2007 15:25:08 -0700
-Subject: Zwiki 0.60 released
-Message-ID: <20070915152508-0700@zwiki.org>
-In-Reply-To: <20070915091937-0700@zwiki.org>
-
-Can't wait any longer! 0.60 must be released! Happy Software Freedom Day!
-
-
-
-From SimonMichael Thu Sep 20 12:14:17 -0700 2007
-From: Simon Michael
-Date: Thu, 20 Sep 2007 12:14:17 -0700
-Subject: Zwiki 0.60 released
-Message-ID: <op.tyyvovg8hse33c@dynabook.joyful.com>
-
-I'm glad to announce the recent release of Zwiki 0.60, breaking the  
-unusually long dry spell since 0.59 in 2007/04. Development has continued  
-at a steady pace, as you can see at the darcsweb link below; also the docs  
-continue to improve at zwiki.org and the issue tracker continues to grind  
-through the mass of issues.
-
-Zope 2.10 and Plone 3 users will want to upgrade to this one. I am  
-tinkering with the development process to try and make us more efficient.  
-We have fun on this project and don't mind sharing it around, so more  
-contributors always welcome!
-
-Best wishes,
--Simon
-
-
-Links:
-
-- http://zwiki.org - documentation, discussion, download, start here
-- http://joyful.com/darcsweb/darcsweb.cgi?r=ZWiki;a=shortlog - commit  
-history
-- http://zwiki.org/FreeHosting - free zwiki hosting
-- http://joyful.com - related sites
-
-
-Release notes:
-
-
-Zwiki 0.60.0 2007/09/15
-=======================
-
-Fix TAL unicode errors with zope 2.10, Plone 3/CMF 2.1 compatibility,
-quicker page rendering, permanent edit history, labelled bracket links,
-better support for custom wiki templates, a tool for importing MoinMoin
-wikis, many other improvements and code cleanups.
-
-Upgrade notes
-   * Zope >=2.10 users should upgrade to this release to avoid TAL unicode  
-errors
-   * Plone 3/CMF 2.1 users should upgrade to this release
-   * Plone 2.x users will not be able to install this release in sites, see  
-#1322 below
-   * a wiki catalog is no longer optional, and will be added if missing
-   * skin customizers should note the wiki navigation links are now in the  
-wikipage template
-
-Installing
-   * #1322: Plone 3 & CMF 2.1 compatibility. Warning, this version of Zwiki
-     uses GenericSetup and is not compatible with older versions of
-     Plone/CMF.  This could be tackled in a future release if there is
-     demand. See the issue page for discussion and possible workarounds.
-
-   * tools/prepmoin.py, imports MoinMoin wiki data to a zwiki (M. Pedersen)
-
-   * #1217: fix setupDtmlPages error (Sascha Welter)
-
-Configuring
-   * fixPageEncoding renamed to fixEncoding and fixed
-
-   * move wiki navigation links to wikipage template for easier customizing
-
-   * #1041, #1145: ensure a catalog and an outline cache are always present.
-
-Browsing
-   * make the home link, wiki logo and index_html use the default page url
-     consistently
-
-   * hide the prefix in mailto: email hyperlinks
-
-   * change long-standing links order: contents before changes, help after
-     options
-
-   * #1348 - redirect to original page after useroptions We are always
-     calling FrontPage/useroptions to limit bot traffic. Now we are
-     carrying the redirectURL through the REQUEST, so we know where to
-     redirect in the end. (Sascha Welter)
-
-   * #1333: make literal/code style more precise to avoid styling difform
-     headings
-
-   * help page cleanup
-
-   * #1145: avoid the broken dtml-in sort option in SearchPage, also, to
-     avoid occasional search errors
-
-   * most access keys are always available, but disable the s subscribeform
-     key if mailout is not enabled, as an extra cue
-
-   * speed up pages by doing less work
-
-   * slight discussionUrl speedup, don't look for UserDiscussion page
-
-   * speed up hasIssues, which was taking half the 2.5s skin render time on
-     zwiki.org
-
-Editing
-   * #1157: replace revertEdits[Everywhere]By with history-wiping expunge,
-     expungeEditsBy, expungeEditsEverywhereBy methods
-
-   * more robust history:
-
-     - allow partial history, revisions can safely be deleted
-     - use a btree folder for revisions if possible
-     - more zodb cache friendly
-     - richer history api
-
-   * new history and diff views. History should now be at least as
-     functional as before, and permanent
-
-   * simple permanent revisions model, use revisions folder instead of
-     recycle_bin
-
-   * stop discarding content outside of html body tags - they may be part
-     of the content
-
-   * #1370: allow arbitrary urls in bracket links
-
-   * optional link labels after | in bracket links
-
-   * #965: avoid infinite recursion error when a page is reparented to  
-itself
-     (Sascha Welter)
-
-   * #570 - Ensure valid id with file uploads.  But meanwhile try to mess
-     with uploaded file's names as little as possible. We check first if
-     the name is acceptable to Zope, and only if it isn't we change
-     it. (Sascha Welter)
-
-   * #1085 - Comments are now properly formatted in HTML pagetype.  Now
-     it's possible to use comments in HTML pagetype pages and have the
-     comments still properly formatted after page edits.  Similar to #1079
-     and therefore again credits and thanks to Martijn Pieters.  We are in
-     the same manner using preRenderMessages to add the comments. (Sascha
-     Welter)
-
-   * #1079 - Plaintext comments work now.  Commenting on plaintext pages
-     would work until you edited the page itself, then the prerendering
-     method lost the comment rendering. Credits go to Martijn Peters for
-     this patch, a bit adapted to code that had moved on.  I had to tweak
-     the output test, as the exact placement of blank lines at end of the
-     page content has changed minimally. (Sascha Welter)
-
-   * refuse any incoming text that's not ascii or utf-8, to avoid problems
-     later
-
-   * createform and create now look only at folder permissions, not the
-     current page, to be consistent with the page management form. The
-     'Zwiki: Add pages' permission is meaningful only on folders, and
-     ignored on pages.
-
-   * #512 - fix footnotes with "create page" links in RST (Sascha Welter)
-
-   * #1323: revert methods now obey the edits_need_username option
-
-   * clean up revertEditsBy, don't break with new pages
-
-Mail
-   * #1256: handle mailins with encodings other than utf8
-
-   * don't log body of mail-ins by default
-
-   * #141 - Uploading a file causes an "edit" mailout now. (Sascha Welter)
-
-   * also allow a 'Secure Maildrop Host' for sending mail (Sascha Welter,
-     Encolpe Degoute)
-
-Feeds
-   * no updates
-
-Issue tracking
-   * yellow color to make open funded issues stand out
-
-   * IssueTracker cleanups
-
-   * #1334: make fuzzy urls work better with issue numbers
-
-   * use html instead of stx page type when installing issue tracker as
-     dtml pages, for a 4x speedup of the unit test on my system
-
-General
-   * many code cleanups including imports, safe_hasattr, deprecation  
-warnings, pyflakes warnings, tests
-
-   * Replace hasattr() with safe_hasattr() everywhere.  Problem with
-     hasattr() is that it masks exceptions, which is known to be
-     problematic. "Our" new safe_hasattr() is from
-     http://www.zope.org/Collectors/Zope/742 - with thanks and credits to
-     Dieter Maurer. (Sascha Welter)
-
-   * #1365 use talsafe() on newname in /editform to avoid
-     UnicodeDecodeError.  This problem appeared in localized browsers only
-     for some reason, but the fix likely is necessary for 2.10 too. (Sascha
-     Welter)
-
-   * #1339 - fixing text encoding for editform.pt textarea. (Sascha Welter)
-
-   * #1330: a better fix for these unicode errors. Zope 2.10 expects TAL
-     data to be unicode, older zopes do not. This can lead to many obscure
-     unicode errors depending on your system locale, wiki content, cookies,
-     phase of the moon etc. This fix aims to make all the standard
-     templates robust against this. Wikis with old customized templates
-     will still be vulnerable to this problem after upgrading to zope 2.10,
-     until those templates are updated.
-
-   * partial workaround for #1330 UnicodeDecodeError
-
-   * Default wiki type is "basic" + added 'jpeg' fs templating. (Sascha
-     Welter)
-
-   * #1332 - fix for the fix + default wiki_type is "basic".  We're now not
-     trying to grab the REQUEST from self any more -- just doesn't make
-     sense to me. Also we have now the default wiki_type as
-     "basic". (Sascha Welter)
-
-   * #1332 - make manage_addWiki more programmatic + test.  We still
-     grabbed the REQUEST and thus got a redirect at the 2nd chance.  Now
-     we're doing the same check as on the 1st test and also return the new
-     id if we don't redirect. Added a test too. (Sascha Welter)
-
-   * Recursively add files/folders on addWikiFromFs.  This is used for
-     "nautica" style templates. It's now possible to use templates
-     e.g. from openwebdesign.org without having to "unroll" images into a
-     flat structure. Also we now can set document titles and parents from
-     the filesystem pages. (Sascha Welter)
-
-   * #1331, #1186 - last_edit_date / creation_date timestamps now in
-     ISO6801.  We changed the timestamp format for last_edit_date and
-     creation_date to conform to ISO8601, in order to save time zone
-     information along with it. Special care is taken to upgrading old
-     timestamps in Zope's DateTime's ISO() format. (Sascha Welter)
-
-   * update stx code, may work better with zope 2.10
-
-   * revisionInfoFor -> revisionInfo
-
-   * inPlone method
-
-Translations
-   * no updates
-
-
-From Rusty Thu Sep 20 20:59:52 -0700 2007
-From: Rusty
-Date: Thu, 20 Sep 2007 20:59:52 -0700
-Subject: !WikiNameEscacpe is not working
-Message-ID: <20070920205952-0700@zwiki.org>
-
-I'm running zwiki 0.59.0 w/ !MoinMoin formatting and placing ! in front of a !WikiName is not escaping it. Anyone know what the problem is? All !WikiNames in this post have been escaped.
-
-From SimonMichael Fri Sep 21 06:31:10 -0700 2007
-From: Simon Michael
-Date: Fri, 21 Sep 2007 06:31:10 -0700
-Subject: !WikiNameEscape not working in moin page type
-Message-ID: <op.ty0ah1fvhse33c@dynabook.joyful.com>
-In-Reply-To: <20070920205952-0700@zwiki.org>
-
-You're right! Forwarded to the issue tracker.
-
-On Thu, 20 Sep 2007 20:59:53 -0700, Rusty <zwiki@zwiki.org> wrote:
-
-| > I'm running zwiki 0.59.0 w/ !MoinMoin formatting and placing ! in front
-| > of a !WikiName is not escaping it. Anyone know what the problem is?
-
-
-
-
-From simon Mon Sep 24 22:53:31 -0700 2007
-From: simon
-Date: Mon, 24 Sep 2007 22:53:31 -0700
-Subject: make pages more indexable
-Message-ID: <20070924225331-0700@zwiki.org>
-
-Zwiki has a standard feature designed to prevent wiki spam being indexed (which tends to make the wiki a spam magnet): pages edited within the last 24 hours have a noindex header.  In other words, a 24-hour cool-off period before indexing can take place. Via baijum, I heard of a complaint from mgedmin about the zope3 wiki not being google friendly due to the noindex header. Thinking about it, the 24 hour rule seems to have an obvious problem that an actively-edited page might never get indexed! I'm guessing that mgedmin saw page not appearing in google as quickly as he expected. I think we have higher expectations of the speed of search indexing nowadays. 
-
-So I've turned off that feature for all wiki.zope.org wikis (by customizing the head.pt template). And I guess it needs to be dropped from Zwiki, as it seems to do a bit more harm than good. Tell me what you think.
-
-From simon Tue Sep 25 09:18:06 -0700 2007
-From: simon
-Date: Tue, 25 Sep 2007 09:18:06 -0700
-Subject: make pages more indexable
-Message-ID: <20070925091806-0700@zwiki.org>
-In-Reply-To: <20070924225331-0700@zwiki.org>
-
-Sent the patch to PatchDiscussion. And I guess I'll move this thread to the IssueTracker so we can find it in future.  Poor old GeneralDiscussion! It's all happening elsewhere.
-
-From FrankLaurijssens Wed Sep 26 08:04:04 -0700 2007
-From: FrankLaurijssens
-Date: Wed, 26 Sep 2007 08:04:04 -0700
-Subject: On a lighter note
-Message-ID: <20070926080404-0700@zwiki.org>
-
-I'm going to use Zwiki again as a project tool, within Plone 3.
-
-From SimonMichael Wed Sep 26 10:56:08 -0700 2007
-From: Simon Michael
-Date: Wed, 26 Sep 2007 10:56:08 -0700
-Subject: On a lighter note
-Message-ID: <46FA9D2C.1080906@joyful.com>
-In-Reply-To: <20070926080404-0700@zwiki.org>
-
-Excellent news! It will be good to have another of us poking at zwiki in 
-plone 3.
-
-
-From simon Fri Sep 28 09:55:00 -0700 2007
-From: simon
-Date: Fri, 28 Sep 2007 09:55:00 -0700
-Subject: restview
-Message-ID: <20070928095500-0700@zwiki.org>
-
-Just released: an offline rst viewer from Marius Gedminas, with python code highlighting. 
-"Pass the name of a ReStructuredText document to restview, and it will launch a web server on localhost:random-port and open a web browser. Every time you reload the page, restview will reload the document from disk and render it. This is very convenient for previewing a document while you're editing it."
-
-http://mg.pov.lt/restview/
-
-From betabug Tue Oct 9 22:41:40 -0700 2007
-From: betabug
-Date: Tue, 09 Oct 2007 22:41:40 -0700
-Subject: Problems submitting patches
-Message-ID: <20071009224140-0700@zwiki.org>
-
-Have tried to send in a few patches. Not sure where they should go now:
-
-- darcs wants to send them to patches@ by default, if I do that, nothing happens, they don't appear on PatchDiscussion
-- if I send them to zwiki-repo@, then I get a delivery failure message "Command died with status 2"
-
-From SimonMichael Wed Oct 10 08:17:26 -0700 2007
-From: Simon Michael
-Date: Wed, 10 Oct 2007 08:17:26 -0700
-Subject: Problems submitting patches
-Message-ID: <470CED05.7050304@joyful.com>
-In-Reply-To: <20071009224140-0700@zwiki.org>
-
-
-> - darcs wants to send them to patches@ by default, if I do that, nothing happens, they don't appear on PatchDiscussion
->   
-We've resolve this for now. Sascha does darcs sends from a different 
-email address, which needed to be subscribed somewhere in the wiki (we 
-chose FrontPage so he wouldn't get duplicate comments). This shows that 
-patch senders also need to be wiki subscribers before their patch will 
-be seen. Hm.
-
-> - if I send them to zwiki-repo@, then I get a delivery failure message 
-That address has been retired for the moment and shouldn't be used.
-
-
-From FrankLaurijssens Mon Oct 15 08:07:13 -0700 2007
-From: FrankLaurijssens
-Date: Mon, 15 Oct 2007 08:07:13 -0700
-Subject: I'm sorry
-Message-ID: <20071015080713-0700@zwiki.org>
-
-I couldn't help but add a few open issues. ;)
-
-From SimonMichael Thu Oct 18 07:45:44 -0700 2007
-From: Simon Michael
-Date: Thu, 18 Oct 2007 07:45:44 -0700
-Subject: cleanup
-Message-ID: <op.t0edxxevhse33c@dynabook.joyful.com>
-In-Reply-To: <op.t0ede6c2hse33c@dynabook.joyful.com>
-
-PS I have been (re)learning about refactoring in python. This may be  
-obvious, but what I'm doing is looking for big methods and trying to break  
-them up. (I'd love a tool to print method lengtch stats, anyone ?) Also  
-I'm trying to use more intention-revealing code. As we keep breaking  
-things up into meaningful verbs we will end up with more of a DSL (domain  
-specific language) which we can express things in with more reuse.
-
-Sometimes this means I add a line or two, to create a named variable to  
-clarify the purpose. I don't mind that if it makes things clearer and more  
-extractable. Next maybe I'll create a local function in the method, then  
-sometimes I'll move that out to an instance method. A few of these are  
-general functions and don't really need to be instance methods, but I  
-leave them there for the time being just so they're nearby.
-
-I'm being a bit careful about method naming since I don't want to expose  
-dangerous things in the public web api, those which need to be private I  
-am prefixing with _ (not relying on docstrings because I want to provide  
-those most of the time.) Right now the _ prefix is a bit inconsistent and  
-distracts from free refactoring, we should probably either apply it  
-consistently across everything, or make it so nothing is published by  
-default and explicitly define which methods are public (I favour that).
-
-
-From SimonMichael Thu Oct 18 07:49:21 -0700 2007
-From: Simon Michael
-Date: Thu, 18 Oct 2007 07:49:21 -0700
-Subject: cleanup
-Message-ID: <op.t0ed3yoihse33c@dynabook.joyful.com>
-In-Reply-To: <op.t0edxxevhse33c@dynabook.joyful.com>
-
-Oops, that was a followup to PatchDiscussion. If you're a  
-GeneralDiscussion page subscriber and want to see more about the code,  
-don't forget to subscribe over there too (or better, the whole wiki).
-
-
-From SimonMichael Thu Oct 18 07:53:59 -0700 2007
-From: Simon Michael
-Date: Thu, 18 Oct 2007 07:53:59 -0700
-Subject: cleanup
-Message-ID: <op.t0eebgujhse33c@dynabook.joyful.com>
-In-Reply-To: <op.t0edxxevhse33c@dynabook.joyful.com>
-
-PPS I'm doing this to make the code more fun to work on, and allow better  
-progress on everything else (Unicode, testing, bugfixing etc.).
-
-Join in, it's fun! The main criteria for a refactoring or cleanup is that  
-the tests pass before, you make the code clearer and probably shorter than  
-before, without changing the behaviour, and the tests pass after. No  
-refactoring is too small!

This page is the easiest way to get involved in Zwiki discussions. Post any questions or comments using the comment form at the bottom of the page. Click subscribe if you'd like to receive (and send) comments by email. For the discussion archives, and other ways to discuss Zwiki, see AboutZwikiDiscussion?.

**Another Z*wiki! ** --DeanG?, Mon, 05 Nov 2007 06:33:47 -0800 reply

http://www.mooseyard.com/Jens/2007/11/review-zackandwiki/ Good for a couple chuckles. :-)

Captcha --flemmingbjerke, Mon, 05 Nov 2007 19:08:14 -0800 reply

I try to make a captcha for zwiki by adding a captchatest to checkSufficientId in Utils.py. However, I am unable to fetch the user inserted code from checkSufficientId. The REQUEST object does not seem to have any form variables, which I don't really understand.

Captcha --betabug, Tue, 06 Nov 2007 00:23:31 -0800 reply

Hmm, I can't confirm this, I've placed a line with print REQUEST.form in checkSufficientId() and it printed out the form fields just fine. It wouldn't make any sense if checkSufficientId() did not have a REQUEST, as we are trying to get the username from the REQUEST in there.

Are you perhaps running this from unit tests? In the test environment we do not always have a real request.

Captcha --flemmingbjerke, Tue, 06 Nov 2007 15:07:42 -0800 reply

Yes, you are right, but. If I change checkSufficientId (where capcode is the code inserted):

def checkSufficientId(self, REQUEST=None):
    REQUEST = REQUEST or getattr(self,'REQUEST',None)
    print REQUEST.form.get('capcode')
    return (self.requestHasUsername(REQUEST) or
            not getattr(self,'edits_need_username',0))

And I start zope with runzope. Then I get:

  • gggggggggggg
  • None
  • None
  • None
  • None
  • None
  • None
  • (ggggggggg is the capcode inserted).
  • None

Here I use Plone where I have put captcha in the comment template in portal_skins. If I insert "print REQUEST.form" and uses a zwiki outside Plone, I get:

  • {'comment': 'add a comment', 'subject_heading': 'dddddddddvvvvvvvvvvvv', 'timeStamp': '1194319308.35', 'use_heading': '1', 'text': 'vvvvvvvvvvvvvvvvvv', 'in_reply_to': '', 'page': 'WikiWikiWeb?'}
  • {}
  • {}
  • {}
  • {}
  • {}
  • {}
  • {}

Probably, here is the reason why I have problems. I seems like a comment implies that checkSufficientId is run 8 times, where only the first time has a proper REQUEST object. This means that a successful captcha test would be wiped out 7 times. (I use zwiki-0.59 because I still use Plone-2.5.3.)

Captcha --betabug, Wed, 07 Nov 2007 00:16:15 -0800 reply

OK, now I think I understand better what you are trying to do. I tried out the same print REQUEST.form and noticed the following:

  • when I'm logged in (e.g. as manager in the ZMI), it prints out 7 results for each page view and another (8th) if I add a comment
  • when I'm not logged in, it prints nothing on normal page requests, and one result if I add a comment

(This is on an almost completely closed down test wiki, on an open wiki more prints will happen for anonymous users.)

Conclusion 1: Some places in the page rendering code check privileges and "sufficient ID" status to decide if displaying user interface elements. This might be slightly inefficient, but I doubt it - we're getting stuff from REQUEST, which is straightforward.

Conclusion 2: You seem to try to return False if your captcha code is not found - and since for a logged in user that code is not found quite often, all kind of stuff stops working.

Conclusion of the conclusions: Your approach is wrong, you are inserting your captcha test in the wrong place. Instead of extending checkSufficientId, better make a new method checkCaptchaCode and place a single check of that method in the relevant spot (somewhere in Editing.py, where checkSufficientId is used).

If you need help with this (of anyway it would be useful I'd say), please open a new issue with severity "wishlist" and we should bring the discussion there. Also feel free to come to #zwiki on freenode and I might help you there in (more or less) realtime.

Captcha --flemmingbjerke, Wed, 07 Nov 2007 13:50:06 -0800 reply

Using checkCaptchaCode 8 or 7 each time you edit or add a comment, isn't it overkill?

I have opened a new issue: [Captcha On Zwiki]?.

**Installing on Windows ** --BrianKennison?, Wed, 07 Nov 2007 15:13:15 -0800 reply

Hey everyone,

I was trying to help some people today who need/want a wiki but they have to work on Windows. I told the person that I'd come and help and was thinking it would be a breeze. Well...

Zope installed easily (package by Enfield Systems) but getting ZWiki? upacked was hard. Rather than having to deal with a gnu zip/unix tar file (.tgz) I was wondering how much trouble it would be to put up a Windows friendly archive?

I tried Winzip today but the free version didn't want to convert the file. I tried 7-z but no luck there. I finally installed cygwin just to unpack ZWiki?.

What do you think?

-- Brian Kennison

**Installing on Windows ** --FrankLaurijssens?, Wed, 07 Nov 2007 23:07:18 -0800 reply

Two things:

1 when you download the file with Internet Explorer, make sure you do save it as a .tgz file, because IE tends to change the extension to .tar.tar. It does that based on MIME type and it really shouldn't.

2 At least WinRAR?, but I thought WinZip? as well, can unpack .tgz files. The evaluation version of WinRAR? works fine.

**Installing on Windows ** --BrianKennison?, Thu, 08 Nov 2007 06:36:24 -0800 reply

I didn't notice that IE was changing the extension to tar. Winzip would try to open it but complain about the headers. Winzip opens it fine with the tgz extension. Thanks for the tip. --Brian