Old discussion of Zwiki code patches.

darcs patch: rename changes_rss to edits_rss (with a backwards comp... --simon, Tue, 18 Sep 2007 23:14:18 -0700 reply

Tue Sep 18 08:21:35 PDT 2007 simon@joyful.com
* rename changes_rss to edits_rss (with a backwards compatibility alias) and
update the docstring. Also, test forwarding to the PatchDiscussion2007 page.

darcs patch: mailin test comment --simon, Wed, 19 Sep 2007 10:54:10 -0700 reply

Wed Sep 19 10:53:28 PDT 2007 simon@joyful.com
* mailin test comment

darcs patch: remove the anti-spam 24 hour indexing delay introduced... --simon, Tue, 25 Sep 2007 09:16:32 -0700 reply

Tue Sep 25 09:16:11 PDT 2007 Simon Michael <simon@joyful.com>
* remove the anti-spam 24 hour indexing delay introduced in 0.41, for better
indexing of actively-edited pages (#1387)

darcs patch: remove the anti-spam 24 hour indexing delay introduced... --Simon Michael, Wed, 26 Sep 2007 10:54:43 -0700 reply

simon wrote: > Tue Sep 25 09:16:11 PDT 2007 Simon Michael <simon@joyful.com> > * remove the anti-spam 24 hour indexing delay introduced in 0.41, for better indexing of actively-edited pages (#1387)

In it goes.

darcs patch: a google sitemap.xml, installed by setupDtmlMethod.. m... --simon, Thu, 27 Sep 2007 13:18:56 -0700 reply

Thu Sep 27 13:17:35 PDT 2007 simon@joyful.com
* a google sitemap.xml, installed by setupDtmlMethod.. may reduce load from search bots

darcs patch: wording --simon, Wed, 10 Oct 2007 08:06:37 -0700 reply

Wed Oct 10 08:06:24 PDT 2007 simon@joyful.com
* wording

darcs patch: Change content-type of the SomePage?/text (or /src) met... --betabug.darcs, Wed, 10 Oct 2007 08:12:49 -0700 reply

Tue Oct 9 11:57:48 EEST 2007 betabug.darcs@betabug.ch
* Change content-type of the SomePage?/text (or /src) methods to UTF-8.
Makes the /text view of wiki pages much more usefull for non-ascii languages.

darcs patch: wording - applied --Simon Michael, Wed, 10 Oct 2007 08:19:26 -0700 reply

**darcs patch: Change content-type of the SomePage?/text (or /src)
met... - applied** --Simon Michael, Wed, 10 Oct 2007 08:19:52 -0700 reply

betabug.darcs wrote: > Tue Oct 9 11:57:48 EEST 2007 betabug.darcs@betabug.ch > * Change content-type of the SomePage?/text (or /src) methods to UTF-8. > Makes the /text view of wiki pages much more usefull for non-ascii languages. > >

darcs patch: Fix test_setupDtmlMethods for sitemap.xm... (and 1 more) --betabug.darcs, Wed, 10 Oct 2007 09:24:17 -0700 reply

Wed Oct 3 21:32:55 EEST 2007 betabug.darcs@betabug.ch
* Fix test_setupDtmlMethods for sitemap.xml.dtml.
Wed Oct 3 21:40:29 EEST 2007 betabug.darcs@betabug.ch
* Catch only AttributeError? instead of bare except clause (in old fix for #1137).
**darcs patch: Fix test_setupDtmlMethods for sitemap.xm... (and 1 more)
  • applied** --Simon Michael, Wed, 10 Oct 2007 09:34:39 -0700 reply

Applied.

darcs patch: notes update --simon, Wed, 10 Oct 2007 09:41:26 -0700 reply

Wed Oct 10 09:39:32 PDT 2007 simon@joyful.com
* notes update

darcs patch: notes update - applied --Sascha Welter, Wed, 10 Oct 2007 09:53:15 -0700 reply

fine with me :-)

(Wed, Oct 10, 2007 at 09:41:26AM -0700) simon wrote/schrieb/egrapse: > Wed Oct 10 09:39:32 PDT 2007 simon@joyful.com > * notes update > >

darcs patch: notes update - applied --Simon Michael, Wed, 10 Oct 2007 09:57:56 -0700 reply

It looks like our patch review/discussion/approval process is working. Yay!

darcs patch: Zope version path changed in >=2.9, bare except removed. --betabug.darcs, Sat, 13 Oct 2007 10:25:08 -0700 reply

Sat Oct 13 20:17:56 EEST 2007 betabug.darcs@betabug.ch
* Zope version path changed in >=2.9, bare except removed.

darcs patch: Zope version path changed in >=2.9, bare except removed. --Simon Michael, Sat, 13 Oct 2007 10:36:42 -0700 reply

Applied, thanks. Sorry I can't join in the hacking today (taxes!)

darcs patch: os.mkdir will raise OSError?, removed bare except. --betabug.darcs, Sat, 13 Oct 2007 11:43:15 -0700 reply

Sat Oct 13 21:42:05 EEST 2007 betabug.darcs@betabug.ch
* os.mkdir will raise OSError?, removed bare except.

darcs patch: removed some unused code in ZWikiPage.py --simon, Sat, 13 Oct 2007 12:13:18 -0700 reply

Sat Oct 13 12:05:49 PDT 2007 Simon Michael <simon@joyful.com>
* removed some unused code in ZWikiPage.py

darcs patch: Catch only AttributeError? for self.DestinationURL?(). --betabug.darcs, Sat, 13 Oct 2007 13:45:27 -0700 reply

Sat Oct 13 22:11:37 EEST 2007 betabug.darcs@betabug.ch
* Catch only AttributeError? for self.DestinationURL?().

darcs patch: removed some unused code in ZWikiPage.py --Sascha Welter, Sat, 13 Oct 2007 13:47:52 -0700 reply

(Sat, Oct 13, 2007 at 12:13:19PM -0700) simon wrote/schrieb/egrapse: > Sat Oct 13 12:05:49 PDT 2007 Simon Michael <simon@joyful.com> > * removed some unused code in ZWikiPage.py

Applied. Cleaning up is a good thing :-)

darcs patch: Catch only AttributeError? for self.DestinationURL?(). --Simon Michael, Sat, 13 Oct 2007 14:45:05 -0700 reply

Applied, applied..

darcs patch: make bare page rendering at the debug prompt work agai... --simon, Tue, 16 Oct 2007 10:24:44 -0700 reply

Tue Oct 16 10:23:35 PDT 2007 simon@joyful.com
* make bare page rendering at the debug prompt work again, cleanup

darcs patch: make bare page rendering at the debug pr... (and 1 more) --simon, Tue, 16 Oct 2007 10:40:34 -0700 reply

Tue Oct 16 10:23:35 PDT 2007 simon@joyful.com
* make bare page rendering at the debug prompt work again, cleanup
Tue Oct 16 10:40:06 PDT 2007 simon@joyful.com
* clean up subtopicsEnabled

tip --Simon Michael, Tue, 16 Oct 2007 10:45:40 -0700 reply

A tip: avoid "darcs send -a " when you have unapproved patches, or it will resend them and the mail subject will be less useful.

darcs patch: make bare page rendering at the debug pr... (and 1 more) --Sascha Welter, Tue, 16 Oct 2007 23:50:27 -0700 reply

(Tue, Oct 16, 2007 at 10:40:34AM -0700) simon wrote/schrieb/egrapse: > Tue Oct 16 10:23:35 PDT 2007 simon@joyful.com > * make bare page rendering at the debug prompt work again, cleanup > > Tue Oct 16 10:40:06 PDT 2007 simon@joyful.com > * clean up subtopicsEnabled

Applied.

Got a bit confused reading through the 2nd one, I should find out how I can apply to a local repository to see the code as it is after patching.

darcs patch: cleanupText cleanup --simon, Wed, 17 Oct 2007 10:16:06 -0700 reply

Wed Oct 17 05:36:31 PDT 2007 simon@joyful.com
* cleanupText cleanup

darcs patch: rename cleanup --simon, Wed, 17 Oct 2007 10:16:16 -0700 reply

Wed Oct 17 05:50:51 PDT 2007 simon@joyful.com
* rename cleanup

darcs patch: rename cleanup (and 1 more) --simon, Wed, 17 Oct 2007 19:27:21 -0700 reply

Wed Oct 17 05:50:51 PDT 2007 simon@joyful.com
* rename cleanup
Wed Oct 17 19:23:43 PDT 2007 simon@joyful.com
* file upload code cleanup

darcs patch: cleanupText cleanup --Sascha Welter, Thu, 18 Oct 2007 01:03:15 -0700 reply

(Wed, Oct 17, 2007 at 10:16:08AM -0700) simon wrote/schrieb/egrapse: ... > - # XXX there are updates for this somewhere on zwiki.org > - if DISABLE_JAVASCRIPT: > - t = re.sub(javascriptexpr,r'&lt;disabled 1&gt;',t) ... > + """Clean up incoming text and make sure that it's utf8-encoded.""" > + def checkutf8(s): unicode(t,'utf-8') > + def stripcr(t): return re.sub('rn','n',t) > + def disablejs(t): return re.sub(javascriptexpr,r'&lt;disabled 1&gt;',t) > + checkutf8(t) > + return disablejs(stripcr(t))

What about DISABLE_JAVASCRIPT? Are we getting rid of it? I think there is at least one zwiki out there that has changed this setting, I had someone asking on #zwiki once how to disable javascript stripping.

darcs patch: cleanupText cleanup --Sascha Welter, Thu, 18 Oct 2007 01:34:50 -0700 reply

(Wed, Oct 17, 2007 at 10:16:08AM -0700) simon wrote/schrieb/egrapse: > Wed Oct 17 05:36:31 PDT 2007 simon@joyful.com > * cleanupText cleanup

Applied!

darcs patch: rename cleanup (and 1 more) --Sascha Welter, Thu, 18 Oct 2007 01:38:11 -0700 reply

(Wed, Oct 17, 2007 at 07:27:24PM -0700) simon wrote/schrieb/egrapse: > Wed Oct 17 05:50:51 PDT 2007 simon@joyful.com > * rename cleanup > > Wed Oct 17 19:23:43 PDT 2007 simon@joyful.com > * file upload code cleanup

Applied these 2!

> + def clean(s): return re.sub(r'[rn]?','',s) > + newname = clean(pagename)

I like ''.merge(s.splitlines()) for this kind of thing. Dunno which one is faster (or clearer), but I try to avoid the use of re in general.

darcs patch: rename cleanup (and 1 more) --Sascha Welter, Thu, 18 Oct 2007 01:42:39 -0700 reply

(Thu, Oct 18, 2007 at 01:38:11AM -0700) Sascha Welter wrote/schrieb/egrapse: > I like ''.merge(s.splitlines()) for this kind of thing. Dunno which one > is faster (or clearer), but I try to avoid the use of re in general.

''.join(s.splitlines()) of course...

darcs patch: cleanupText cleanup --Simon Michael, Thu, 18 Oct 2007 07:25:21 -0700 reply

Oh, true. We'll put it back, unless we can think of something smarter.

darcs patch: rename cleanup (and 1 more) --Simon Michael, Thu, 18 Oct 2007 07:34:54 -0700 reply

Thanks! I agree that sometimes a non re solution is better and possibly slightly faster. Generally I don't avoid re though, we use it throughout Zwiki. Let's go with what's clearest.

darcs patch: PUT cleanup --simon, Thu, 18 Oct 2007 22:36:16 -0700 reply

Thu Oct 18 22:35:15 PDT 2007 Simon Michael <simon@joyful.com>
* PUT cleanup

darcs patch: PUT cleanup --Sascha Welter, Thu, 18 Oct 2007 22:39:25 -0700 reply

(Thu, Oct 18, 2007 at 10:37:08PM -0700) simon wrote/schrieb/egrapse: > Thu Oct 18 22:35:15 PDT 2007 Simon Michael <simon@joyful.com> > * PUT cleanup

Applied!

darcs patch: #1393 Catch ValueError? too on importing unknown pagety... --betabug.darcs, Mon, 22 Oct 2007 00:44:52 -0700 reply

Mon Oct 22 10:43:04 EEST 2007 betabug.darcs@betabug.ch
* #1393 Catch ValueError? too on importing unknown pagetypes.

darcs patch: handy new manager methods expungeLastEditor, expungeLa... --simon, Fri, 26 Oct 2007 08:10:45 -0700 reply

Fri Oct 26 08:09:36 PDT 2007 simon@joyful.com
* handy new manager methods expungeLastEditor, expungeLastEditorEverywhere; expunge, expungeEditsEverywhereBy cleanup

darcs patch: handy new manager methods expungeLastEdi... (and 2 more) --simon, Fri, 26 Oct 2007 09:04:23 -0700 reply

Fri Oct 26 08:09:36 PDT 2007 simon@joyful.com
* handy new manager methods expungeLastEditor, expungeLastEditorEverywhere; expunge, expungeEditsEverywhereBy cleanup
Fri Oct 26 09:03:08 PDT 2007 simon@joyful.com
* clarification
Fri Oct 26 09:03:19 PDT 2007 simon@joyful.com
* tests for new expunge methods

darcs patch: setCreatorLike, setLastEditorLike --simon, Fri, 26 Oct 2007 09:21:30 -0700 reply

Fri Oct 26 09:20:05 PDT 2007 simon@joyful.com
* setCreatorLike, setLastEditorLike

darcs patch: handy new manager methods expungeLastEdi... (and 2 more) --Sascha Welter, Sat, 27 Oct 2007 11:39:37 -0700 reply

(Fri, Oct 26, 2007 at 09:04:26AM -0700) simon wrote/schrieb/egrapse: > Fri Oct 26 08:09:36 PDT 2007 simon@joyful.com > * handy new manager methods expungeLastEditor, expungeLastEditorEverywhere; expunge, expungeEditsEverywhereBy cleanup > > Fri Oct 26 09:03:08 PDT 2007 simon@joyful.com > * clarification > > Fri Oct 26 09:03:19 PDT 2007 simon@joyful.com > * tests for new expunge methods

Applied these 3!

Tests! I like tests!

darcs patch: setCreatorLike, setLastEditorLike --Sascha Welter, Sat, 27 Oct 2007 11:40:02 -0700 reply

(Fri, Oct 26, 2007 at 09:21:31AM -0700) simon wrote/schrieb/egrapse: > Fri Oct 26 09:20:05 PDT 2007 simon@joyful.com > * setCreatorLike, setLastEditorLike

Applied too!

darcs patch: revert cleanup --simon, Sat, 27 Oct 2007 11:42:56 -0700 reply

Fri Oct 26 09:20:19 PDT 2007 simon@joyful.com
* revert cleanup

darcs patch: revert cleanup --Sascha Welter, Sat, 27 Oct 2007 11:50:31 -0700 reply

(Sat, Oct 27, 2007 at 11:42:58AM -0700) simon wrote/schrieb/egrapse: > Fri Oct 26 09:20:19 PDT 2007 simon@joyful.com > * revert cleanup

Applied.

darcs patch: move a method (and 10 more) --simon, Sat, 27 Oct 2007 19:03:59 -0700 reply

Sat Oct 27 17:46:55 PDT 2007 simon@joyful.com
* move a method
Sat Oct 27 17:51:22 PDT 2007 simon@joyful.com
* handleEditPageType cleanup
Sat Oct 27 17:52:20 PDT 2007 Simon Michael <simon@joyful.com>
* handleRename cleanup
Sat Oct 27 18:03:21 PDT 2007 Simon Michael <simon@joyful.com>
* delete cleanup, drop unused updatebacklinks argument
Sat Oct 27 18:06:17 PDT 2007 Simon Michael <simon@joyful.com>
* handleEditText cleanup
Sat Oct 27 18:08:18 PDT 2007 Simon Michael <simon@joyful.com>
* handleSubtopicsProperty cleanup
Sat Oct 27 18:14:27 PDT 2007 simon@joyful.com
* append, edit cleanup
Sat Oct 27 18:17:15 PDT 2007 Simon Michael <simon@joyful.com>
* autoSubscriptionEnabled cleanup
Sat Oct 27 18:40:19 PDT 2007 simon@joyful.com
* comment cleanup
Sat Oct 27 18:41:32 PDT 2007 Simon Michael <simon@joyful.com>
* move methods
Sat Oct 27 19:02:34 PDT 2007 Simon Michael <simon@joyful.com>
* create cleanup. All significant methods in Editing have now been reviewed/tightened up.

darcs patch: move a method (and 11 more) --simon, Sat, 27 Oct 2007 19:24:43 -0700 reply

Sat Oct 27 17:46:55 PDT 2007 simon@joyful.com
* move a method
Sat Oct 27 17:51:22 PDT 2007 simon@joyful.com
* handleEditPageType cleanup
Sat Oct 27 17:52:20 PDT 2007 Simon Michael <simon@joyful.com>
* handleRename cleanup
Sat Oct 27 18:03:21 PDT 2007 Simon Michael <simon@joyful.com>
* delete cleanup, drop unused updatebacklinks argument
Sat Oct 27 18:06:17 PDT 2007 Simon Michael <simon@joyful.com>
* handleEditText cleanup
Sat Oct 27 18:08:18 PDT 2007 Simon Michael <simon@joyful.com>
* handleSubtopicsProperty cleanup
Sat Oct 27 18:14:27 PDT 2007 simon@joyful.com
* append, edit cleanup
Sat Oct 27 18:17:15 PDT 2007 Simon Michael <simon@joyful.com>
* autoSubscriptionEnabled cleanup
Sat Oct 27 18:40:19 PDT 2007 simon@joyful.com
* comment cleanup
Sat Oct 27 18:41:32 PDT 2007 Simon Michael <simon@joyful.com>
* move methods
Sat Oct 27 19:02:34 PDT 2007 Simon Michael <simon@joyful.com>
* create cleanup. All significant methods in Editing have now been reviewed/tightened up.
Sat Oct 27 19:24:06 PDT 2007 simon@joyful.com
* oops! not running tests enough. Two typos and one bugfix

darcs patch: move a method (and 11 more) --Sascha Welter, Sun, 28 Oct 2007 00:47:12 -0700 reply

(Sat, Oct 27, 2007 at 07:24:47PM -0700) simon wrote/schrieb/egrapse: > Sat Oct 27 17:46:55 PDT 2007 simon@joyful.com > * move a method > > Sat Oct 27 17:51:22 PDT 2007 simon@joyful.com > * handleEditPageType cleanup > > Sat Oct 27 17:52:20 PDT 2007 Simon Michael <simon@joyful.com> > * handleRename cleanup > > Sat Oct 27 18:03:21 PDT 2007 Simon Michael <simon@joyful.com> > * delete cleanup, drop unused updatebacklinks argument > > Sat Oct 27 18:06:17 PDT 2007 Simon Michael <simon@joyful.com> > * handleEditText cleanup > > Sat Oct 27 18:08:18 PDT 2007 Simon Michael <simon@joyful.com> > * handleSubtopicsProperty cleanup > > Sat Oct 27 18:14:27 PDT 2007 simon@joyful.com > * append, edit cleanup > > Sat Oct 27 18:17:15 PDT 2007 Simon Michael <simon@joyful.com> > * autoSubscriptionEnabled cleanup > > Sat Oct 27 18:40:19 PDT 2007 simon@joyful.com > * comment cleanup > > Sat Oct 27 18:41:32 PDT 2007 Simon Michael <simon@joyful.com> > * move methods > > Sat Oct 27 19:02:34 PDT 2007 Simon Michael <simon@joyful.com> > * create cleanup. All significant methods in Editing have now been reviewed/tightened up. > > Sat Oct 27 19:24:06 PDT 2007 simon@joyful.com > * oops! not running tests enough. Two typos and one bugfix

Reviewed and applied all of them :-)

darcs patch: Remove mentions of purple numbers in comments. --betabug.darcs, Mon, 29 Oct 2007 10:43:46 -0700 reply

Mon Oct 29 19:41:14 EET 2007 betabug.darcs@betabug.ch
* Remove mentions of purple numbers in comments.

darcs patch: Switched to OOBTree? for recording votes. --betabug.darcs, Mon, 29 Oct 2007 14:24:55 -0700 reply

Mon Oct 29 23:22:56 EET 2007 betabug.darcs@betabug.ch
* Switched to OOBTree? for recording votes.

darcs patch: Switched to OOBTree? for recording votes. --Simon Michael, Mon, 29 Oct 2007 14:59:26 -0700 reply

Cool, thanks.

darcs patch: Switched to OOBTree? for recording votes. --Sascha Welter, Mon, 29 Oct 2007 15:07:51 -0700 reply

(Mon, Oct 29, 2007 at 02:59:27PM -0700) Simon Michael wrote/schrieb/egrapse: > Cool, thanks. > > - Could you rerecord this with just a little more detail in the comment, ie why you did it

OK, I'm all for long comments :-) ... how do I rerecord?

> - I'd like to start updating CHANGES.txt incrementally, maybe you could add a note there too.

Good.

> - will this work with zope 2.7 ?

Yes, it's only the BTreeFolder2? that isn't by default in Zope 2.7, BTrees? were there even then. But I'll try tomorrow to be sure.

darcs patch: Switched to OOBTree? for recording votes. --Simon Michael, Mon, 29 Oct 2007 16:08:02 -0700 reply

Since it's only in your repo right now (I assume), just: make sure you have no unrecorded changes, darcs unrecord and select just that patch, then record again.

darcs patch: Switched to OOBTree? for recording ratings. --betabug.darcs, Tue, 30 Oct 2007 01:46:07 -0700 reply

Tue Oct 30 10:39:21 EET 2007 betabug.darcs@betabug.ch
* Switched to OOBTree? for recording ratings.
Dictionaries on persistant objects in the ZODB can only be saved by
writing all of the object to the ZODB again. Inefficient. We're using
a BTree? now, which will save us some kB writing to disk and also
reduces the likelyhood of ConflictErrors? on the page.
On accessting the "votes" we check for old votes still being
dictionaries, moving them to BTrees? on-the-fly. The overhead for this
is counterbalanced by easier recording of votes, just set the entry
in the BTree?.

darcs patch: Switched to OOBTree? for recording ratings. (and 1 more) --betabug.darcs, Tue, 30 Oct 2007 01:56:07 -0700 reply

Tue Oct 30 10:39:21 EET 2007 betabug.darcs@betabug.ch
* Switched to OOBTree? for recording ratings.
Dictionaries on persistant objects in the ZODB can only be saved by
writing all of the object to the ZODB again. Inefficient. We're using
a BTree? now, which will save us some kB writing to disk and also
reduces the likelyhood of ConflictErrors? on the page.
On accessting the "votes" we check for old votes still being
dictionaries, moving them to BTrees? on-the-fly. The overhead for this
is counterbalanced by easier recording of votes, just set the entry
in the BTree?.
Tue Oct 30 10:54:20 EET 2007 betabug.darcs@betabug.ch
* Update only rating related indexes in catalog.
We're saving some bytes by updating only the indexes actually
related to voting. All metadata will unfortunately be updated anyway.

darcs patch: Recorded rating change. --betabug.darcs, Tue, 30 Oct 2007 04:09:05 -0700 reply

Tue Oct 30 13:05:12 EET 2007 betabug.darcs@betabug.ch
* Recorded rating change.
We want to update CHANGES incrementally. Attempting to find a form for
that here, which at the release could be changed quickly to the final
release CHANGES.

darcs patch: Recorded rating change. --Simon Michael, Tue, 30 Oct 2007 09:57:16 -0700 reply

All applied.

darcs patch: make linecounts (and 2 more) --Simon Michael, Fri, 02 Nov 2007 10:50:28 -0700 reply

Sat Oct 27 23:29:25 PDT 2007 simon@joyful.com
* make linecounts
Sat Oct 27 23:29:37 PDT 2007 simon@joyful.com
* a little whitespace
Sun Oct 28 01:04:28 PDT 2007 Simon Michael <simon@joyful.com>
* clarify that handleEditText permissions check

darcs patch: start a developer style guide, with some documentation... --Simon Michael, Fri, 02 Nov 2007 10:50:39 -0700 reply

Fri Nov 2 10:48:59 PDT 2007 Simon Michael <simon@joyful.com>
* start a developer style guide, with some documentation guidelines

darcs patch: format mailed-in darcs patches as a literal block --Simon Michael, Fri, 02 Nov 2007 11:13:58 -0700 reply

Fri Nov 2 11:13:24 PDT 2007 Simon Michael <simon@joyful.com>
* format mailed-in darcs patches as a literal block

literal quoting, take two --Simon Michael, Fri, 02 Nov 2007 11:22:42 -0700 reply

Fri Nov 2 11:20:55 PDT 2007 Simon Michael <simon@joyful.com>
* format mailed-in darcs patches as a literal block

darcs patch: make linecounts (and 2 more) --Sascha Welter, Sat, 03 Nov 2007 12:28:10 -0700 reply

(Fri, Nov 02, 2007 at 10:50:32AM -0700) Simon Michael wrote/schrieb/egrapse: > Sat Oct 27 23:29:25 PDT 2007 simon@joyful.com > * make linecounts > > Sat Oct 27 23:29:37 PDT 2007 simon@joyful.com > * a little whitespace

Applied.

> Sun Oct 28 01:04:28 PDT 2007 Simon Michael <simon@joyful.com> > * clarify that handleEditText permissions check

Applied too. I very much like this one, clarifies it quite nice.

darcs patch: start a developer style guide, with some documentation... --Sascha Welter, Sat, 03 Nov 2007 12:32:10 -0700 reply

(Fri, Nov 02, 2007 at 10:50:40AM -0700) Simon Michael wrote/schrieb/egrapse: > Fri Nov 2 10:48:59 PDT 2007 Simon Michael <simon@joyful.com> > * start a developer style guide, with some documentation guidelines

Applied.

literal quoting, take two --Sascha Welter, Sat, 03 Nov 2007 12:42:55 -0700 reply

(Fri, Nov 02, 2007 at 11:22:43AM -0700) Simon Michael wrote/schrieb/egrapse: > Fri Nov 2 11:20:55 PDT 2007 Simon Michael <simon@joyful.com> > * format mailed-in darcs patches as a literal block

This one wouldn't apply to my local repo :-(

It says "darcs failed: Malformed patch bundle: '[format mailed-in darcs patches as a literal block' is not 'Context:'"

literal quoting, take two --Simon Michael, Sun, 04 Nov 2007 06:46:57 -0800 reply

Ah. Of course, the prepended space for rst literal-quoting makes it no longer a valid darcs patch. Darn.

darcs patch: move some style docs out of ZWikiPage.py --Simon Michael, Sun, 04 Nov 2007 07:38:30 -0800 reply

Sun Nov 4 07:37:56 PST 2007 Simon Michael <simon@joyful.com>
* move some style docs out of ZWikiPage.py

move style docs, take two --Simon Michael, Sun, 04 Nov 2007 07:46:56 -0800 reply

Sun Nov 4 07:44:20 PST 2007 Simon Michael <simon@joyful.com>
* move/update some old style docs

move style docs, take two --Sascha Welter, Sun, 04 Nov 2007 08:14:01 -0800 reply

(Sun, Nov 04, 2007 at 07:46:58AM -0800) Simon Michael wrote/schrieb/egrapse: > Sun Nov 4 07:44:20 PST 2007 Simon Michael <simon@joyful.com> > * move/update some old style docs

Applied!

darcs patch: add a doc file overview to README --Simon Michael, Sun, 04 Nov 2007 08:40:25 -0800 reply

Sun Nov 4 08:39:44 PST 2007 Simon Michael <simon@joyful.com>
* add a doc file overview to README

darcs patch: directory overview & more style notes --Simon Michael, Sun, 04 Nov 2007 08:47:21 -0800 reply

Sun Nov 4 08:46:49 PST 2007 Simon Michael <simon@joyful.com>
* directory overview & more style notes

darcs patch: more coding style notes --Simon Michael, Sun, 04 Nov 2007 09:34:10 -0800 reply

Sun Nov 4 09:32:59 PST 2007 Simon Michael <simon@joyful.com>
* more coding style notes

darcs patch: more coding style notes --Sascha Welter, Sun, 04 Nov 2007 10:51:45 -0800 reply

(Sun, Nov 04, 2007 at 09:34:12AM -0800) Simon Michael wrote/schrieb/egrapse: > Sun Nov 4 09:32:59 PST 2007 Simon Michael <simon@joyful.com> > * more coding style notes

Applied, these are all very useful.

darcs patch: 1348 - Quote the redirect URL for the "options" page. --betabug.darcs, Mon, 05 Nov 2007 10:03:29 -0800 reply

Mon Nov 5 19:58:06 EET 2007 betabug.darcs@betabug.ch
* 1348 - Quote the redirect URL for the "options" page.
This is ammending "1348 - Setting useroptions now returns to previous page",
the URL in a POST variable should be properly quoted. It usually works without
this, but it's not correct.

darcs patch: 1348 - Quote the redirect URL for the "options" page. --betabug.darcs, Mon, 05 Nov 2007 10:22:07 -0800 reply

Mon Nov 5 20:19:48 EET 2007 betabug.darcs@betabug.ch
* 1348 - Quote the redirect URL for the "options" page.
This is ammending "1348 - Setting useroptions now returns to previous page",
the URL in a POST variable should be properly quoted. It usually works
without this, but it's not correct.

darcs patch: 1348 - Quote the redirect URL for the "options" page. --Sascha Welter, Mon, 05 Nov 2007 10:22:40 -0800 reply

(Mon, Nov 05, 2007 at 10:03:35AM -0800) betabug.darcs wrote/schrieb/egrapse: > Mon Nov 5 19:58:06 EET 2007 betabug.darcs@betabug.ch > * 1348 - Quote the redirect URL for the "options" page. > This is ammending "1348 - Setting useroptions now returns to previous page", > the URL in a POST variable should be properly quoted. It usually works without > this, but it's not correct.

Please forget this one, there is an amended one coming next.

darcs patch: 1391 - fixed "Footer 'create' button without page name... --betabug.darcs, Mon, 05 Nov 2007 10:53:52 -0800 reply

Mon Nov 5 20:50:15 EET 2007 betabug.darcs@betabug.ch
* 1391 - fixed "Footer 'create' button without page name results in AttributeError?"
In this case the name of the new page is not entered from the initial
"footer" form, but only on the edit/create page.

darcs patch: 1348 - Quote the redirect URL for the "options" page. --Simon Michael, Mon, 05 Nov 2007 11:07:02 -0800 reply

Thanks.. do we need this extra argument ? Is there a reason we wouldn't redirect, when there's a REQUEST ?

darcs patch: 1348 - Quote the redirect URL for the "options" page. --Sascha Welter, Mon, 05 Nov 2007 11:10:14 -0800 reply

(Mon, Nov 05, 2007 at 11:07:04AM -0800) Simon Michael wrote/schrieb/egrapse: > Thanks.. do we need this extra argument ? Is there a reason we wouldn't redirect, when there's a REQUEST ? >

I think it's just clearer, given the method name. The method name doesn't really suggest a redirection or quoting happening. One could argue that the default is to redirect + quote now though... the main point should be that we are quoting now.

darcs patch: 1348 - Quote the redirect URL for the "options" page. --Simon Michael, Mon, 05 Nov 2007 11:17:52 -0800 reply

I'm not convinced.. I really don't see the need for an extra flag. If redirectURL is provided, we should just redirect there, no ?

darcs patch: 1391 - fixed "Footer 'create' button without page name... --Simon Michael, Mon, 05 Nov 2007 11:23:10 -0800 reply

I'm not clear on this yet. The issue at hand is about clicking the create button on the normal page view, right ? What should it do in that case when page name is blank, what does it do with this patch ?

darcs patch: 1391 - fixed "Footer 'create' button without page name... --Simon Michael, Mon, 05 Nov 2007 11:31:50 -0800 reply

We discussed this on #zwiki, agreed that the page management form/createform/editform/edit method field names/arguments need cleanup, but this is a good step forward. Thanks Sascha, applying this one.

**ammended/simplified 1348 - Quote the redirect URL for the "options"
page.** --betabug.darcs, Mon, 05 Nov 2007 11:58:54 -0800 reply
Mon Nov 5 21:57:29 EET 2007 betabug.darcs@betabug.ch
* 1348 - Quote the redirect URL for the "options" page.
This is ammending "1348 - Setting useroptions now returns to previous page",
the URL in a POST variable should be properly quoted. It usually works without
this, but it's not correct.
**ammended/simplified 1348 - Quote the redirect URL for the "options"
page.** --Simon Michael, Wed, 07 Nov 2007 09:07:32 -0800 reply

(resend) Applied, thanks.

darcs patch: 962 - Show form on issue pages in HTML m... (and 1 more) --betabug.darcs, Sun, 18 Nov 2007 00:56:50 -0800 reply

Sat Nov 17 16:49:17 EET 2007 betabug.darcs@betabug.ch
* 962 - Show form on issue pages in HTML markup.
Sat Nov 17 17:02:26 EET 2007 betabug.darcs@betabug.ch
* 1352 - remove further (last?) hasattr() calls.
Since these are in dtml or pt code, we replace them with getattr()
calls, so we don't have to import our safe_hasattr() here. It would
be nice if Zope had a built in safe_hasattr().

darcs patch: 1391 - fixed "Footer 'create' button without page name... --betabug.darcs, Wed, 12 Dec 2007 09:01:27 -0800 reply

Mon Nov 5 20:50:15 EET 2007 betabug.darcs@betabug.ch
* 1391 - fixed "Footer 'create' button without page name results in AttributeError?"
In this case the name of the new page is not entered from the initial
"footer" form, but only on the edit/create page.

darcs patch: 1391 - fixed "Footer 'create' button without page name... --Sascha Welter, Sat, 15 Dec 2007 06:32:17 -0800 reply

(Mon, Nov 05, 2007 at 11:31:51AM -0800) Simon Michael wrote/schrieb/egrapse: > We discussed this on #zwiki, agreed that the page management > form/createform/editform/edit method field names/arguments need > cleanup, but this is a good step forward. Thanks Sascha, applying this > one.

I think this apply didn't make it through. (Because of the domain trouble?)

**ammended/simplified 1348 - Quote the redirect URL for the "options"
page.** --Sascha Welter, Sat, 15 Dec 2007 06:33:34 -0800 reply

(Wed, Nov 07, 2007 at 09:07:36AM -0800) Simon Michael wrote/schrieb/egrapse: > (resend) Applied, thanks.

Same here, I think the apply got cought in the domain trouble or something.

darcs patch: 1391 - fixed "Footer 'create' button wit... (and 1 more) --betabug.darcs, Sat, 15 Dec 2007 06:41:50 -0800 reply

Mon Nov 5 20:50:15 EET 2007 betabug.darcs@betabug.ch
* 1391 - fixed "Footer 'create' button without page name results in AttributeError?"
In this case the name of the new page is not entered from the initial
"footer" form, but only on the edit/create page.
Mon Nov 26 20:06:46 EET 2007 betabug.darcs@betabug.ch
* 1017 - clicking create without pagename gives friendlier error now.
This probably isn't perfect (user has to click the browsers "back"
button), but I believe it's much, much better than displaying a
traceback.

darcs patch: 1347 - summary() not quoted + cleanup. --betabug.darcs, Sat, 15 Dec 2007 06:43:13 -0800 reply

Tue Nov 27 08:24:51 EET 2007 betabug.darcs@betabug.ch
* 1347 - summary() not quoted + cleanup.
Original issue was about summary() being quoted, which isn't always
desirable. Looking at it I noticed that docstrings for summary() and
renderedSummary() do not reflect actual output, e.g. summary()
returns RST markup, not just plain text. Added a wikilinkedSummary()
method too, which is plaintext, but with active links - this could
also have been done with an optional parameter to renderedSummary().

patches applied --Simon Michael, Sat, 15 Dec 2007 09:44:27 -0800 reply

Thanks! All applied except the summary patch, which we discussed on #zwiki.

darcs patch: 1397 - fix revert by re-adding setVotes. --betabug.darcs, Sat, 22 Dec 2007 01:55:56 -0800 reply

Sat Dec 22 02:07:04 EET 2007 betabug.darcs@betabug.ch
* 1397 - fix revert by re-adding setVotes.
While rebuilding the rating/voting mechanism I had deleted setVotes()
since revert() wants to use setVotes() to reset the votes, reverting
resulted in an ugly traceback.

darcs patch: Added some functional tests. (and 1 more) --betabug.darcs, Sun, 23 Dec 2007 02:45:22 -0800 reply

Sat Dec 22 20:56:11 EET 2007 betabug.darcs@betabug.ch
* Added some functional tests.
These are implemented using zope.testbrowser, that's why they will
unfortunately only run on Zope 2.10. The tests basically mimic a browser
going through some page edits. In that way the tests provide a nice
high-level walkthrough. They are using doctest syntax and therefore it's
easy to add more. For an overview of the syntax, see:
SOFTWARE_HOME/zope/testbrowser/README.txt
Sat Dec 22 21:12:29 EET 2007 betabug.darcs@betabug.ch
* Print a note about Functional tests not running <2.10.