Submitted by : simon at: 2007-05-17T16:33:29-07:00 (13 years ago)
Name :
Category : Severity : Status :
Optional subject :  
Optional comment :

I'm seeing problems with the new expunge?rev= and expungeEdits(Everywhere)By?username= methods. One case fails with:

* Module Products.ZWiki.Editing, line 544, in expungeEditsBy
* Module Products.ZWiki.History, line 152, in revisionNumberBefore
AttributeError None has no such attr..

(betabug taking notes here while looking at the code:

line numbers have moved around, but I suspect that this happens in the line:

if self.revision(r).lastEditor() != username:

in revisionNumberBefore(), since revision() can return None - would have been nice to have the full traceback, to see what the AttributeError? was looking for)

Another seems to succeed, but the page object is broken afterward - you can't even manage it. It says:

* Module Products.PageTemplates.ZRPythonExpr, line 49, in __call__
  __traceback_info__: request.RESPONSE.setHeader( 'Content-Type','text/html; charset='+charset)
* Module PythonExpr, line 1, in <expression>
* Module ZPublisher.HTTPRequest, line 1233, in __getattr__
AttributeError RESPONSE

ie request somehow has no RESPONSE.

Clarifications from #zwiki:

< sm> expunge* wipe out history - good for spam cleanup
< betabug> ah, ok
< betabug> and the failure is reproducible?
< sm> yes